feat(ACI): Set up deletions for Incident model #89227
Merged
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89227 +/- ##
==========================================
+ Coverage 85.22% 87.70% +2.47%
==========================================
Files 10103 10109 +6
Lines 571685 571969 +284
Branches 22476 22476
==========================================
+ Hits 487226 501622 +14396
+ Misses 84038 69926 -14112
Partials 421 421 |
snigdhas
approved these changes
Apr 9, 2025
wedamija
reviewed
Apr 10, 2025
There was a problem hiding this comment.
Not sure if this is a problem, but we might need to be careful here that when we drop Incidents fully that we don't end up cascade deleting GroupOpenPeriod. Probably it won't be an issue, because we'll just remove references to the model and drop it, rather than deleting rows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we delete an
Incidentwe want to be sure that we're also deleting the correspondingIncidentGroupOpenPeriodand theGroupOpenPeriod.