feat(trace-eap-waterfall): Adding support for occurrences #89221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 9, 2025 13:31
github-actions
bot
added
the
Scope: Frontend
Co-authored-by: Abdullah Khan <[email protected]>
edwardgou-sentry
approved these changes
Apr 9, 2025
Comment on lines
87
to
90
| } else { | ||
| if (o.event_id === event.occurrence?.id) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
nit: you can combine this into a single } else if {
| makeEAPSpan({ | ||
| event_id: 'eap-span-2', | ||
| is_transaction: false, | ||
| occurrences: [makeEAPOccurence({event_id: 'eap-occurence-1'})], |
There was a problem hiding this comment.
nit: looks like there are some areas with the occurence typo. Not a big deal, but you might want to global search on occurence and follow up in another pr.
|
I skipped reviewing changes from the last commit, since that looks like it was merged in from a different PR that was already reviewed. |
billyvg
pushed a commit
that referenced
this pull request
Apr 14, 2025
Stacked PR fixing typo: #89225 This PR adds support for eap occurences in the trace waterfall. The bulk of the change revolves around adding the new type below, that now come attached to eap spans: ``` type EAPOccurrence = { event_id: string; event_type: 'occurrence'; issue_id: number; level: Level; project_id: number; project_slug: string; start_timestamp: number; transaction: string; description?: string; }; ``` <img width="1256" alt="Screenshot 2025-04-09 at 5 26 28 PM" src="https://github.com/user-attachments/assets/c506b1ee-55ab-4b76-9f88-7b69e987a287" /> --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PR fixing typo: #89225
This PR adds support for eap occurences in the trace waterfall. The bulk of the change revolves around adding the new type below, that now come attached to eap spans: