-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(utils): SDK name tag normalizer #59504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll create a separate PR to un-revert adding SDK tags using this normalizer. |
import functools | ||
import re | ||
|
||
_KNOWN_TAGS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ellisonmarks the unique values for SDK tag would be reduced to this list + "other", so as it stands now, 42 unique values. Is that an acceptable cardinality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vartec - after our iterations, what's the new count?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lobsterkatie 36 total (35 known + "other")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we started with, what, 270ish? that’s really not too shabby! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
Co-authored-by: Katie Byers <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #59504 +/- ##
=======================================
Coverage 80.75% 80.76%
=======================================
Files 5171 5172 +1
Lines 226911 226928 +17
Branches 38148 38152 +4
=======================================
+ Hits 183250 183273 +23
+ Misses 38104 38101 -3
+ Partials 5557 5554 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Co-authored-by: Katie Byers <[email protected]>
…ics (#59572) This re-applies previously reverted #59379 combining it with #59504 to normalize SDK tags reducing their cardinality. Implements: #59053 --------- Co-authored-by: Katie Byers <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
…ics (#59572) This re-applies previously reverted #59379 combining it with #59504 to normalize SDK tags reducing their cardinality. Implements: #59053 --------- Co-authored-by: Katie Byers <[email protected]> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
#59501 Normalizes SDK tags to reduce their cardinality.
Related to #59075 and #59379.
"other"
)sentry.javascript.*
are mostly kept as-issentry.native.*
are collapsed to 3 levelssentry.*
are collapsed to 2 levels