fix(expo-context): All values should be lowercase #4809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
force-pushed
the
kw-fix-expo-context-lower-case
branch
from
f4b4e38 to
7d9928b
Compare
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 270.25 ms | 290.85 ms | 20.60 ms |
| b7eb05d+dirty | 335.90 ms | 338.98 ms | 3.08 ms |
| 61310e1+dirty | 463.51 ms | 511.09 ms | 47.57 ms |
| 5bb8d5f+dirty | 356.71 ms | 389.65 ms | 32.94 ms |
| ad6c299+dirty | 336.47 ms | 362.89 ms | 26.42 ms |
| 7d161c0+dirty | 383.35 ms | 398.73 ms | 15.38 ms |
| 60d7316+dirty | 475.43 ms | 535.26 ms | 59.84 ms |
| 9b5b3f4+dirty | 395.85 ms | 396.73 ms | 0.88 ms |
| 48ad514+dirty | 419.34 ms | 441.48 ms | 22.14 ms |
| 686b3bc+dirty | 363.48 ms | 356.17 ms | -7.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 7.15 MiB | 8.38 MiB | 1.22 MiB |
| b7eb05d+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 61310e1+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
| 5bb8d5f+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
| ad6c299+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
| 7d161c0+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 60d7316+dirty | 7.15 MiB | 8.38 MiB | 1.22 MiB |
| 9b5b3f4+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 48ad514+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 686b3bc+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 690220d+dirty | 1228.27 ms | 1233.55 ms | 5.29 ms |
| 2ec71da+dirty | 1225.85 ms | 1231.57 ms | 5.72 ms |
| 366c2d0+dirty | 1232.29 ms | 1240.86 ms | 8.57 ms |
| d16beca+dirty | 1215.94 ms | 1228.20 ms | 12.27 ms |
| f06c879+dirty | 1252.64 ms | 1259.66 ms | 7.02 ms |
| 0ebca77+dirty | 1220.75 ms | 1222.81 ms | 2.06 ms |
| ea85ff8+dirty | 1220.35 ms | 1220.73 ms | 0.39 ms |
| 1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
| a0b0298+dirty | 1220.73 ms | 1226.87 ms | 6.14 ms |
| 025d490+dirty | 1237.51 ms | 1238.34 ms | 0.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 690220d+dirty | 2.36 MiB | 3.10 MiB | 753.57 KiB |
| 2ec71da+dirty | 2.36 MiB | 3.13 MiB | 784.66 KiB |
| 366c2d0+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| d16beca+dirty | 2.36 MiB | 3.12 MiB | 779.39 KiB |
| f06c879+dirty | 2.36 MiB | 2.88 MiB | 530.42 KiB |
| 0ebca77+dirty | 2.36 MiB | 3.04 MiB | 698.33 KiB |
| ea85ff8+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| 1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
| a0b0298+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 025d490+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 690220d+dirty | 1227.45 ms | 1221.67 ms | -5.78 ms |
| 2ec71da+dirty | 1230.29 ms | 1239.50 ms | 9.21 ms |
| 366c2d0+dirty | 1210.81 ms | 1219.60 ms | 8.79 ms |
| d16beca+dirty | 1239.00 ms | 1233.89 ms | -5.11 ms |
| f06c879+dirty | 1285.14 ms | 1285.86 ms | 0.72 ms |
| 0ebca77+dirty | 1209.30 ms | 1220.33 ms | 11.03 ms |
| ea85ff8+dirty | 1211.96 ms | 1211.85 ms | -0.11 ms |
| 1c65324+dirty | 1239.71 ms | 1239.86 ms | 0.15 ms |
| a0b0298+dirty | 1227.71 ms | 1234.12 ms | 6.41 ms |
| 025d490+dirty | 1205.27 ms | 1206.15 ms | 0.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 690220d+dirty | 2.92 MiB | 3.66 MiB | 758.77 KiB |
| 2ec71da+dirty | 2.92 MiB | 3.69 MiB | 791.06 KiB |
| 366c2d0+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| d16beca+dirty | 2.92 MiB | 3.69 MiB | 790.48 KiB |
| f06c879+dirty | 2.92 MiB | 3.44 MiB | 533.24 KiB |
| 0ebca77+dirty | 2.92 MiB | 3.61 MiB | 705.12 KiB |
| ea85ff8+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| 1c65324+dirty | 2.92 MiB | 3.61 MiB | 705.56 KiB |
| a0b0298+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 025d490+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
krystofwoldrich
force-pushed
the
kw-expo-updates-native-crashes
branch
from
671ff96 to
3b4708c
Compare
krystofwoldrich
force-pushed
the
kw-fix-expo-context-lower-case
branch
from
7d9928b to
7e5b016
Compare
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 80b2ce3 | 385.02 ms | 387.36 ms | 2.34 ms |
| 8bda0cc | 450.38 ms | 433.89 ms | -16.49 ms |
| 457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
| 7d161c0 | 413.02 ms | 435.29 ms | 22.26 ms |
| ddc0552 | 472.92 ms | 460.66 ms | -12.26 ms |
| 07e58c9 | 495.04 ms | 489.73 ms | -5.31 ms |
| 950b04f | 433.92 ms | 462.43 ms | 28.51 ms |
| 3f05680 | 397.91 ms | 405.65 ms | 7.74 ms |
| e73d82f | 475.82 ms | 506.55 ms | 30.73 ms |
| 2de79dc | 435.31 ms | 416.96 ms | -18.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 80b2ce3 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 8bda0cc | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
| 7d161c0 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| ddc0552 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
| 07e58c9 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 950b04f | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 3f05680 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| e73d82f | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 2de79dc | 17.75 MiB | 20.13 MiB | 2.38 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
From testing we noticed that on iOS the values are upper case.
💚 How did you test it?
unit tests
📝 Checklist
sendDefaultPIIis enabled