Skip to content

ci: Update v5 CI #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 2, 2024
Merged

ci: Update v5 CI #4310

merged 9 commits into from
Dec 2, 2024

Conversation

krystofwoldrich
Copy link
Member

This PR backports CI fixes done in past week on the main branch back to v5, so we are able to release patches of v5 with confidence and passing tests. :)

@krystofwoldrich krystofwoldrich changed the base branch from main to v5 November 25, 2024 16:55
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 432.58 ms 540.14 ms 107.56 ms
Size 17.73 MiB 20.11 MiB 2.38 MiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.59 ms 1229.00 ms 3.41 ms
Size 2.36 MiB 3.14 MiB 794.58 KiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.83 ms 429.64 ms 33.81 ms
Size 7.15 MiB 8.39 MiB 1.24 MiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 2, 2024 15:42
Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.65 ms 1233.12 ms -0.52 ms
Size 2.92 MiB 3.69 MiB 795.21 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for porting the fixes to v5 🙇

@krystofwoldrich krystofwoldrich merged commit 8ecf121 into v5 Dec 2, 2024
60 of 61 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/ci/v5-update branch December 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants