Skip to content

fix(replay): browserReplayIntegration should not be included by default #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 3, 2024

Conversation

krystofwoldrich
Copy link
Member

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 377.77 ms 463.02 ms 85.25 ms
Size 7.15 MiB 8.39 MiB 1.24 MiB

Previous results on branch: kw/backport/replay-web-fix

Startup times

Revision Plain With Sentry Diff
e5fcbef+dirty 378.50 ms 414.70 ms 36.20 ms

App size

Revision Plain With Sentry Diff
e5fcbef+dirty 7.15 MiB 8.39 MiB 1.24 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for back-porting this fix 🙇

l: The Lint failure could be fixed by formatting the sdk.test.ts.
I think the rest of the CI check failures are unrelated with this PR (signing issues, testing device availability etc).

@krystofwoldrich
Copy link
Member Author

Sadly, the v5 CI is out of date, we have to fix it first, unrelated to changes in this PR.

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should make a follow-up PR to fix CI

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 443.92 ms 446.02 ms 2.10 ms
Size 17.73 MiB 20.11 MiB 2.38 MiB

Previous results on branch: kw/backport/replay-web-fix

Startup times

Revision Plain With Sentry Diff
e5fcbef 420.20 ms 404.10 ms -16.10 ms

App size

Revision Plain With Sentry Diff
e5fcbef 17.73 MiB 20.11 MiB 2.38 MiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.53 ms 1225.28 ms -7.26 ms
Size 2.36 MiB 3.14 MiB 794.53 KiB

Previous results on branch: kw/backport/replay-web-fix

Startup times

Revision Plain With Sentry Diff
e5fcbef+dirty 1230.09 ms 1229.35 ms -0.74 ms

App size

Revision Plain With Sentry Diff
e5fcbef+dirty 2.36 MiB 3.14 MiB 794.58 KiB

Copy link
Contributor

github-actions bot commented Dec 2, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1248.04 ms 1245.10 ms -2.94 ms
Size 2.92 MiB 3.69 MiB 795.16 KiB

@krystofwoldrich krystofwoldrich merged commit 5f56c92 into v5 Dec 3, 2024
53 of 55 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/backport/replay-web-fix branch December 3, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants