Skip to content

Introduce underscore span attributes #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 28, 2025

Introduce the convention of underscore-prefixed span attributes. These won't be sent to Sentry and are meant for internal SDK usage.

Changed flag.count to internal. Looked through the rest of the attrs we're setting and that stuff requires a big comprehensive cleanup altogether to make stuff align with OTel. Didn't touch anything else for now.

Closes #4329

@sentrivana sentrivana changed the title Slim down outgoing payload Introduce underscore span attributes Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (5b6d37c) to head (8a729a8).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/opentelemetry/span_processor.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           potel-base    #4331      +/-   ##
==============================================
- Coverage       84.39%   84.38%   -0.01%     
==============================================
  Files             144      144              
  Lines           14632    14636       +4     
  Branches         2325     2327       +2     
==============================================
+ Hits            12348    12350       +2     
- Misses           1558     1560       +2     
  Partials          726      726              
Files with missing lines Coverage Δ
sentry_sdk/tracing.py 80.49% <100.00%> (ø)
sentry_sdk/opentelemetry/span_processor.py 81.81% <83.33%> (+0.45%) ⬆️

... and 1 file with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review April 28, 2025 13:39
@sentrivana sentrivana requested a review from a team as a code owner April 28, 2025 13:39
@sentrivana sentrivana merged commit a5d0f01 into potel-base Apr 28, 2025
129 checks passed
@sentrivana sentrivana deleted the ivana/potel/slim-down-attrs branch April 28, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants