Skip to content

Deprecate Span.set_data() #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 9, 2025
Merged

Deprecate Span.set_data() #4261

merged 4 commits into from
Apr 9, 2025

Conversation

antonpirker
Copy link
Member

Refs #4102

@antonpirker antonpirker requested a review from a team as a code owner April 9, 2025 11:22
@antonpirker antonpirker requested review from sentrivana and removed request for sentrivana April 9, 2025 11:23
@antonpirker antonpirker marked this pull request as draft April 9, 2025 11:23
@antonpirker antonpirker mentioned this pull request Apr 9, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
20448 1 20447 4415
View the top 1 failed test(s) by shortest run time 
tests.test_basics test_classmethod_tracing
Stack Traces | 0.156s run time 
tests/test_basics.py:811: in test_classmethod_tracing
    assert fake_start_child.call_count == 1
E   AssertionError: assert 2 == 1
E    +  where 2 = <MagicMock name='mock.start_child' id='140166058444640'>.call_count

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker marked this pull request as ready for review April 9, 2025 11:45
@antonpirker antonpirker requested a review from sentrivana April 9, 2025 11:45
sentrivana
sentrivana approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻
Please also add to MIGRATION_GUIDE

@antonpirker
Copy link
Member Author

Updated.

@antonpirker antonpirker merged commit cd0c8ff into potel-base Apr 9, 2025
@antonpirker antonpirker deleted the antonpirker/potel/deprecate-set-data branch April 9, 2025 13:13
@antonpirker antonpirker mentioned this pull request Apr 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana