fix(feedback): Ensure pluggable feedback CDN bundle is correctly built #13081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Jul 29, 2024
| jsVersion: 'es6', | ||
| licenseTitle: '@sentry-internal/feedback', | ||
| outputFileBase: () => 'bundles/feedback', | ||
| sucrase: { |
There was a problem hiding this comment.
These don't appear to be necessary (anymore?), it seems to be working fine without this as well (we also don't set this in the existing index.bundle.feedback config in browser)
c298lee
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13080
This was basically just wrong - we need stuff from
browserpackage there, so we can't really build the final CDN bundle from the feedback-internal package.I moved this over and also adjusted tests to actually test this with pluggable CDN integrations as well.