Skip to content

feat (feedback) - Make cropped screenshot area draggable #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

joemmalatesta
Copy link
Contributor

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).fe

This addition adds an intuitive way to resize screenshots in the user feedback widget. The draggable area is bound by the canvas box (so it won't overflow) and is only draggable when cropped (when confirm/cancel buttons present)

Screen.Recording.2024-07-26.at.11.12.58.AM.mov

@joemmalatesta joemmalatesta self-assigned this Jul 26, 2024
@joemmalatesta joemmalatesta requested a review from a team as a code owner July 26, 2024 18:22
@c298lee
Copy link
Contributor

c298lee commented Jul 26, 2024

this is sick! thanks for adding this feature!!

@bruno-garcia
Copy link
Member

wow awesome one! Thanks @joemmalatesta
cc @jas-kas

@c298lee
Copy link
Contributor

c298lee commented Jul 26, 2024

Closes #11166

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.31 KB (0%)
@sentry/browser (incl. Tracing) 33.72 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.82 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.16 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.21 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 86.78 KB (+0.24% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 88.66 KB (+0.24% 🔺)
@sentry/browser (incl. metrics) 26.62 KB (0%)
@sentry/browser (incl. Feedback) 39.23 KB (+0.54% 🔺)
@sentry/browser (incl. sendFeedback) 26.93 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.57 KB (0%)
@sentry/react 25.08 KB (0%)
@sentry/react (incl. Tracing) 36.8 KB (0%)
@sentry/vue 26.45 KB (0%)
@sentry/vue (incl. Tracing) 35.61 KB (0%)
@sentry/svelte 22.44 KB (0%)
CDN Bundle 23.52 KB (0%)
CDN Bundle (incl. Tracing) 35.5 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.86 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.15 KB (0%)
CDN Bundle - uncompressed 69 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 105.1 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 216.74 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.57 KB (0%)
@sentry/nextjs (client) 36.66 KB (0%)
@sentry/sveltekit (client) 34.39 KB (0%)
@sentry/node 111.76 KB (0%)
@sentry/node - without tracing 89.21 KB (+0.01% 🔺)
@sentry/aws-serverless 98.34 KB (0%)

@joemmalatesta joemmalatesta merged commit a880712 into develop Jul 26, 2024
122 checks passed
@joemmalatesta joemmalatesta deleted the joemmalatesta-make-screenshot-area-draggable branch July 26, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants