ref(feedback): Let CropCorner inherit the existing h prop #12814
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this after #12784, but the
<CropCorner>
wasn't inside theScreenshotEditorFactory()
function. So of course it wasn't getting access to theh
ref that is passed in. That variable is what the<div>
gets transpiled into -> it becomesh.createElement('div')
.So what i'm doing is moving
CropCorner
into aCropCornerFactory
so we can passh
in and hopefully not have the extraimport .. from 'preact';
in the 2nd bundle.Related to #12535