fix(tracing): Report dropped spans for transactions #12751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already report a client report for dropped standalone spans. However, so far we did not report any for spans dropped for transactions.
This PR also emits a client report when
beforeSendSpan
is used to filter a span of a transaction, as well as when the whole transaction is dropped inbeforeSendTransaction
.For now, we do not emit this if users manually drop single spans in e.g.
beforeSendTransaction
, which I'd say is OK for now.Closes #12727