Skip to content

fix(tracing): Report dropped spans for transactions #12751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 4, 2024

We already report a client report for dropped standalone spans. However, so far we did not report any for spans dropped for transactions.

This PR also emits a client report when beforeSendSpan is used to filter a span of a transaction, as well as when the whole transaction is dropped in beforeSendTransaction.

For now, we do not emit this if users manually drop single spans in e.g. beforeSendTransaction, which I'd say is OK for now.

Closes #12727

@mydea mydea self-assigned this Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

size-limit report 📦

Path Size
@sentry/browser 22.27 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) 33.42 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing, Replay) 69.17 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.5 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.23 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.84 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.71 KB (+0.06% 🔺)
@sentry/browser (incl. metrics) 26.56 KB (+0.21% 🔺)
@sentry/browser (incl. Feedback) 38.91 KB (+0.14% 🔺)
@sentry/browser (incl. sendFeedback) 26.89 KB (+0.17% 🔺)
@sentry/browser (incl. FeedbackAsync) 31.5 KB (+0.15% 🔺)
@sentry/react 25.01 KB (+0.19% 🔺)
@sentry/react (incl. Tracing) 36.47 KB (+0.13% 🔺)
@sentry/vue 26.38 KB (+0.19% 🔺)
@sentry/vue (incl. Tracing) 35.28 KB (+0.13% 🔺)
@sentry/svelte 22.4 KB (+0.21% 🔺)
CDN Bundle 23.48 KB (+0.23% 🔺)
CDN Bundle (incl. Tracing) 35.17 KB (+0.14% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.26 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.46 KB (+0.07% 🔺)
CDN Bundle - uncompressed 68.92 KB (+0.18% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 103.94 KB (+0.12% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.33 KB (+0.06% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.04 KB (+0.06% 🔺)
@sentry/nextjs (client) 36.35 KB (+0.13% 🔺)
@sentry/sveltekit (client) 34.06 KB (+0.14% 🔺)
@sentry/node 130.74 KB (+0.04% 🔺)
@sentry/node - without tracing 91.75 KB (+0.05% 🔺)
@sentry/aws-serverless 116.93 KB (+0.04% 🔺)

@mydea mydea changed the title fix: Report dropped spans for transactions fix(tracing): Report dropped spans for transactions Jul 4, 2024
@mydea mydea merged commit ef7e5b6 into develop Jul 4, 2024
114 of 115 checks passed
@mydea mydea deleted the fn/span-client-report branch July 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report dropped spans in client reports
2 participants