fix(browser): Improve browser extension error message check #12146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
lforst,
s1gr1d and
AbhiPrasad
and removed request for
a team
mydea
force-pushed
the
lms/fix-browser-extension-detection
branch
from
23e966a to
ed286fd
Compare
mydea
reviewed
May 22, 2024
| return !!isInsideBrowserExtension || !!isInsideChromeExtension; | ||
| const windowWithMaybeExtension = WINDOW as typeof WINDOW & ExtensionProperties; | ||
|
|
||
| const extensionKey = windowWithMaybeExtension.chrome ? 'chrome' : 'browser'; |
There was a problem hiding this comment.
to clarify, when would you have window.browser.xxx, and would that mean this is an extension??
There was a problem hiding this comment.
Yes, we introduced this in the original browser extension check (https://github.com/getsentry/sentry-javascript/pull/10844/files)
mydea
approved these changes
May 22, 2024
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our check for when we abort and log an error due to
Sentry.initbeing used in a browser extension a bit more fine-gained. In particular, we now do not abort the SDK initialization if we detect that the SDK is running in a browser-extension dedicated window (e.g. a URL starting withchrome-extension://).This was raised in #12025. h/t @Thomas101 for providing the initial idea how to check for the dedicated pages. I expanded on the check a bit to add other browsers. This list is not complete but probably good enough for start.
Also rewrote the function a bit to hopefully save a few bytes 🤞