Skip to content

v8 Node OpenTelemetry Instrumentation Blockers #12242

Closed
@AbhiPrasad

Description

@AbhiPrasad

With the release of v8 of the Sentry SDK, the Node SDK now relies on OpenTelemetry. OpenTelemetry instrumentation does have some problems though (particularly with ESM because of import-in-the-middle), so this issue aims at documented these gaps.

import-in-the-middle

These are import-in-the-middle bugs, which are encountered by Sentry users who want to use Sentry in their ESM app.

### `import-in-the-middle` PRs to be merged
- [ ] https://github.com/DataDog/import-in-the-middle/pull/76
- [ ] https://github.com/DataDog/import-in-the-middle/pull/78
- [ ] https://github.com/DataDog/import-in-the-middle/pull/79
- [ ] https://github.com/DataDog/import-in-the-middle/pull/81
- [ ] https://github.com/DataDog/import-in-the-middle/pull/83
- [ ] https://github.com/DataDog/import-in-the-middle/pull/86
- [ ] https://github.com/DataDog/import-in-the-middle/pull/85
- [ ] https://github.com/DataDog/import-in-the-middle/pull/88
- [ ] https://github.com/open-telemetry/opentelemetry-js/pull/4745
- [ ] https://github.com/DataDog/import-in-the-middle/issues/95

1. import-in-the-middle does not work with multiple loaders.

Reported issue: #12011
Node.js issue: nodejs/node#52987

Fix: nodejs/import-in-the-middle#76

2. relative resolution fails for some modules

import-in-the-middle expects modules to be relative to the current file, but this doesn't always apply (re-exporting for example). Instead we should just use node's resolve

Reported issue: #12059
IITM issues: nodejs/import-in-the-middle#59, nodejs/import-in-the-middle#62, nodejs/import-in-the-middle#63

Fix: nodejs/import-in-the-middle#78

3. import-in-the-middle breaks with duplicate wildcard exports

Reported issue: #12154
IITM issue: nodejs/import-in-the-middle#60

Fix: nodejs/import-in-the-middle#79

4. Does not handle import * of current file

Reported issue: #12237
IITM issue: nodejs/import-in-the-middle#82

Fix: nodejs/import-in-the-middle#83

5. Does not handle CallExpression in ExportDefaultDeclaration node

IITM issue: nodejs/import-in-the-middle#77

Fix: nodejs/import-in-the-middle#85

6. tsx and --import seems to not play nicely

Reported issue: #12357

Instrumentation and Span Data Quality

This is being tracked by #12109

Performance Degradation with v8 PR.

### Tasks
- [ ] https://github.com/getsentry/sentry-javascript/issues/12243

PostgresIntegration problems

We've gotten two different reports (#11897, https://discord.com/channels/621778831602221064/1242436171737333810) that using the postgres integration with Sentry is causing memory issues.

Metadata

Metadata

Labels

Package: nodeIssues related to the Sentry Node SDK

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions