User Feedback followup #4494
Merged
User Feedback followup #4494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Scopes.captureFeedback API Changed the MainActivity sample app to use the new API
captureFeedback does not update scope lastEventId anymore
added SentryOptions.beforeSendFeedback implemented SentryClient.captureFeedback
# Conflicts: # CHANGELOG.md # sentry/api/sentry.api # sentry/src/main/java/io/sentry/SentryClient.java
added first draft of SentryUserFeedbackDialog
…idget # Conflicts: # CHANGELOG.md
added feedbackOptions to SentryOptions added callbacks to SentryUserFeedbackDialog
added feedback message truncation SentryClient doesn't check for backfillable feedbacks anymore
…idget # Conflicts: # CHANGELOG.md
added dialog theme to sample app MainActivity "send user feedback" button now opens feedback dialog instead of sending feedback
# Conflicts: # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java # sentry/api/sentry.api # sentry/src/main/java/io/sentry/HubAdapter.java # sentry/src/main/java/io/sentry/HubScopesWrapper.java # sentry/src/main/java/io/sentry/IScopes.java # sentry/src/main/java/io/sentry/NoOpHub.java # sentry/src/main/java/io/sentry/NoOpScopes.java # sentry/src/main/java/io/sentry/Scopes.java # sentry/src/main/java/io/sentry/ScopesAdapter.java # sentry/src/main/java/io/sentry/SentryClient.java # sentry/src/main/java/io/sentry/transport/RateLimiter.java
fixed feedback form behaviour added manifest options
updated changelog
updated changelog
added delegate listener to avoid user overwriting our OnDismissListener for the feedback dialog
# Conflicts: # CHANGELOG.md
MainActivity sendFeedback reverted to call API, with new widget to open dialog Added widget ui tests
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
added SentryUserFeedbackDialog.Builder, allowing a configuration being passed for the current dialog options added SentryFeedbackOptions copy constructor
# Conflicts: # sentry-android-core/api/sentry-android-core.api # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java
# Conflicts: # CHANGELOG.md # sentry-android-core/api/sentry-android-core.api # sentry-android-core/src/main/res/layout/sentry_dialog_user_feedback.xml # sentry-android-integration-tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/UserFeedbackUiTest.kt # sentry-samples/sentry-samples-android/src/main/java/io/sentry/samples/android/MainActivity.java
renamed asset files to sentry_...
Changed FeedbackOptions from String to CharSequence Changed User feedback User name to User username
renamed UF button logo
|
Performance metrics 🚀
|
stefanosiano
requested review from
adinauer,
romtsn,
markushi and
lcian
as code owners
markushi
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Changed logo with vector drawable
Changed FeedbackOptions from String to CharSequence
Changed User feedback User name to User username
💡 Motivation and Context
Addressing PR feedbacks
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps