-
-
Notifications
You must be signed in to change notification settings - Fork 453
Send logcat through Sentry Logs #4487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2e00745 | 440.67 ms | 489.81 ms | 49.14 ms |
296205e | 397.86 ms | 416.63 ms | 18.77 ms |
229d937 | 407.06 ms | 448.72 ms | 41.66 ms |
d035656 | 399.04 ms | 416.73 ms | 17.69 ms |
771a432 | 410.52 ms | 458.84 ms | 48.32 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2e00745 | 1.58 MiB | 2.09 MiB | 518.68 KiB |
296205e | 1.58 MiB | 2.09 MiB | 518.67 KiB |
229d937 | 1.58 MiB | 2.09 MiB | 518.93 KiB |
d035656 | 1.58 MiB | 2.08 MiB | 511.32 KiB |
771a432 | 1.58 MiB | 2.08 MiB | 511.32 KiB |
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md
Hi, this is a feature I am quite keen on, so just dropping some useful (easy to add?) additions
|
hi @ishanzuaim, and thanks for the interest! You can already set the minimum logging level in the gradle plugin options following the logcat integration documentation
We'll discuss how to best send the tag in the logs, too! |
# Conflicts: # CHANGELOG.md # sentry-android-core/src/test/java/io/sentry/android/core/InternalSentrySdkTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryLogcatAdapterTest.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, please check internally regarding attaching the stacktrace.
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java
Outdated
Show resolved
Hide resolved
…at/logcat-sentry-logs
📜 Description
SentryLogcatAdapter now forwards output to Sentry Logs, if enabled
💡 Motivation and Context
Closes #4408
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps