Skip to content

Don't apply Spring Boot plugin in sentry-spring-boot-jakarta #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented May 27, 2025

📜 Description

Restores apply false on the Spring Boot plugin in this module, which was already present before
https://github.com/getsentry/sentry-java/blob/10dfe0c7f208f7c5675f5bf2517d121f938b34b0/sentry-spring-boot-jakarta/build.gradle.kts
It must've been left out by mistake in the version catalog migration

If the plugin is applied then the build will try to run the bootJar task to create an application Jar which will fail.

I'm not sure why CI and/or craft/release action didn't detect this.

💡 Motivation and Context

Fixes #4455

💚 How did you test it?

The jar is present locally

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@lcian lcian changed the title fix: don't apply Spring Boot plugin in sentry-spring-boot-jakarta Don't apply Spring Boot plugin in sentry-spring-boot-jakarta May 27, 2025
@lcian lcian merged commit 591d92a into main May 27, 2025
33 checks passed
@lcian lcian deleted the lcian/fix/boot-jakarta-apply-false branch May 27, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The following artifacts could not be resolved: io.sentry:sentry-spring-boot-jakarta:jar:8.13.1
3 participants