-
-
Notifications
You must be signed in to change notification settings - Fork 453
Read build tool info from sentry-debug-meta.properties
and attach it to events
#4314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
commented
Apr 3, 2025
Performance metrics 🚀
|
lcian
commented
May 6, 2025
adinauer
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM but seems not to be used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Reads the build tool and its version from
sentry-debug-meta.properties
and sends it as part of the packages.The build tool is being written to
sentry-debug-meta.properties
by the plugin (io.sentry.build-tool
set to resp.maven
andgradle
).The plugins don't currently set
io.sentry.build-tool-version
, so if it's not there we fall back to reporting "unknown" as the version.In a future release of the plugin we can make it so they both write
io.sentry.build-tool-version
as well.💡 Motivation and Context
Closes #4142
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps
Change both of the plugins to report
io.sentry.build-tool-version
.