Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Update enriching events page #13237

Merged
merged 6 commits into from
Apr 9, 2025
Merged

feat(js): Update enriching events page #13237

merged 6 commits into from
Apr 9, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 4, 2025

This updates the "Enriching Events" page in the JS docs to be more descriptive, and actually guide you through the different types of data you may add to your Sentry events.

It also:

  1. Adds more details to setUser API
  2. Adds more details to setContext API
  3. Adds the missing sendDefaultPii option
  4. Removes the "Identifying Users" page in favor of just using the setUser API page
  5. Removes the "Contexts" page which was really confusing, as it mixed both explanation of contexts (which is now in setContext API page) as well as general "context" stuff like clearing scope data etc (which does not work anyhow because you need to clear the isolation scope etc... so just removing this for now).

@mydea mydea requested review from stephanie-anderson, lforst, Lms24, s1gr1d and a team April 4, 2025 12:20
@mydea mydea self-assigned this Apr 4, 2025
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 1:15pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 1:15pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2025 1:15pm

@mydea mydea changed the title feat(js): Update enriching events pages feat(js): Update enriching events page Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 525 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -519 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/w3xqen-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/w3xqen-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/2ggWBO4-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/2ggWBO4-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json -170 bytes 384.45kB -0.04%
../app/platform-redirect/page.js.nft.json -170 bytes 384.36kB -0.04%
../app/sitemap.xml/route.js.nft.json -170 bytes 382.33kB -0.04%

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mydea mydea force-pushed the fn/enriching-events branch from 43c1672 to 943633b Compare April 9, 2025 12:19
@mydea mydea merged commit 7a6d357 into master Apr 9, 2025
13 checks passed
@mydea mydea deleted the fn/enriching-events branch April 9, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants