Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): Fix span metrics examples #13227

Merged
merged 3 commits into from
Apr 7, 2025
Merged

fix(js): Fix span metrics examples #13227

merged 3 commits into from
Apr 7, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 4, 2025

This fixes some of the code examples around span metrics in JS.

@mydea mydea requested review from Lms24, codyde and s1gr1d April 4, 2025 08:57
@mydea mydea self-assigned this Apr 4, 2025
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 7, 2025 7:01am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2025 7:01am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 7, 2025 7:01am

Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/wu4DsJVlRdbX5IOwSDI6R/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/wu4DsJVlRdbX5IOwSDI6R/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/tOeYYeBpLdzU-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/tOeYYeBpLdzU-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@codyde codyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the help on this, LGTM!

@mydea mydea merged commit ca2afe4 into master Apr 7, 2025
11 checks passed
@mydea mydea deleted the fn/tracing-docs branch April 7, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants