This repository was archived by the owner on Sep 12, 2023. It is now read-only.
Set rustfmt max comment and line width to 100
#2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a bit weird that the `comment_width` was configured to be _longer_ than the `max_width` which sets the maximum width of each line. I choose to explictly set `max_width` to its default value of 100 for clarity. The reason why we don't see any other changes to the diff should be obvious: setting `comment_width` to more than `max_width` was useless! Inspired by: rust-lang/rustfmt#3349 (comment).
klochowicz
approved these changes
Jul 28, 2022
|
bors r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a bit weird that the
comment_widthwas configured to be longer than themax_widthwhich sets the maximum width of each line.I choose to explicitly set
max_widthto its default value of 100 for clarity.The reason why we don't see any other changes to the diff should be obvious: setting
comment_widthto more thanmax_widthwas useless!Inspired by: rust-lang/rustfmt#3349 (comment).