Don't inject empty interior rings when converting to geo Polygons #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when converting a GeoJson Polygon with no interior rings
to a geo Polygon, we are injecting a single interior ring consisting
of an empty linestring, rather than simply leaving the list of
interior rings empty.
This results in some strange behavior if you do any geojson -> geo_types
-> geojson round-tripping because your polygons end up with an
additional empty ring included.
e.g this:
{"coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]]],
"type":"Polygon"}
becomes:
{"coordinates":
[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]],[]],
"type":"Polygon"}
This change should fix this behavior.
frewsxcv
approved these changes
Jul 8, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 8, 2018
99: Don't inject empty interior rings when converting to geo Polygons r=frewsxcv a=worace
I ran into what I think may be a small bug when using this library in a CLI tool I am working on.
It seems that when converting an exterior-only GeoJson polygon to a geo_types polygon, the library is injecting an empty interior ring rather than simply leaving the interiors field of the geo_types polygon empty.
This results in some surprising behavior if you do any round-trip conversions from geo_types -> GeoJson -> geo_types, since a polygon like this:
```json
{"type":"Polygon",
"coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]]]}
```
becomes:
```json
{"type":"Polygon",
"coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]], []]}
```
I've added a test case here which demonstrates the issue and included what I think is a reasonable approach to fixing it. Hope this is helpful!
I also fixed up a few test-name typos I noticed when I was reading these tests -- hope that is Ok.
Co-authored-by: Horace Williams <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into what I think may be a small bug when using this library in a CLI tool I am working on.
It seems that when converting an exterior-only GeoJson polygon to a geo_types polygon, the library is injecting an empty interior ring rather than simply leaving the interiors field of the geo_types polygon empty.
This results in some surprising behavior if you do any round-trip conversions from geo_types -> GeoJson -> geo_types, since a polygon like this:
{"type":"Polygon", "coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]]]}becomes:
{"type":"Polygon", "coordinates":[[[30.0, 10.0],[10.0, 30.0],[40.0, 40.0],[30.0, 10.0]], []]}I've added a test case here which demonstrates the issue and included what I think is a reasonable approach to fixing it. Hope this is helpful!
I also fixed up a few test-name typos I noticed when I was reading these tests -- hope that is Ok.