Skip to content

Upgrade to serde 0.9 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 4, 2017
Merged

Upgrade to serde 0.9 #60

merged 8 commits into from
Feb 4, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Feb 4, 2017

Continuation of #58

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 4, 2017

@KodrAus What do you think of the changes here? I am using unwrap but I don't think any of them should fail where they're used. I'll look again in the morning when I'm not half asleep 💤

@KodrAus
Copy link
Contributor

KodrAus commented Feb 4, 2017

Ah that's better! Yeh I think the unwrap should always be safe, because there are only Rust types involved.

@frewsxcv frewsxcv merged commit 3d66e79 into master Feb 4, 2017
@frewsxcv frewsxcv deleted the serde-0.9 branch February 4, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants