Streaming feature collection deserializer #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bjornharrtell! This looks like a great addition and I think we'd be delighted to have it. I'm going to leave this open for a few more days to see what others think, but the only real addition I'd like to see is some top-level documentation noting that it's available and pointing to an example. |
|
@urschrei great :) I'll try to find time asap to improve the docs situation. |
|
@urschrei I've added what I think might be good enough docs. I feel example is overkill as the contained unit tests demonstrate the use. |
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This is proposal to add
FeatureIteratorthat can be used to deserialize features from a feature collection in a stream. It is more or less a specialized version of the example code at serde-rs/serde#903 (comment).I'm very new at Rust so please excuse if I have made some rookie mistakes.