-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate Rust 1.86, bump CI MSRV to 1.82 #42
base: main
Are you sure you want to change the base?
Conversation
Presumably these will start passing when Bullseye-1.86 is published |
I re-kicked the build and the 1.86 build was successful! But now this:
geo CI also has MSRV 1.81. Any reason you care about to build containers older than 1.81, or can we drop them? |
No we can get rid… |
58d572a
to
d6151c4
Compare
.github/workflows/imagebuild.yml
Outdated
@@ -22,7 +22,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
rust_version: ["1.75", "1.81", "1.84", "1.85"] | |||
rust_version: ["1.82", "1.85", "1.86"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be 1.81? That's the MSRV we have in geo and proj.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I didn't see your comments in #41. Yeah, let's stick with 1.81 - 1.86 then. This proj situation is such a slog.
d6151c4
to
6d6b20b
Compare
CHANGES.md
orCHANGELOG.md