Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Rust 1.86, bump CI MSRV to 1.82 #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

urschrei
Copy link
Member

@urschrei urschrei commented Apr 3, 2025

  • I agree to follow the project's code of conduct.
  • I added an entry to the project's change log file if knowledge of this change could be valuable to users.
    • Usually called CHANGES.md or CHANGELOG.md
    • Prefix changelog entries for breaking changes with "BREAKING: "

@urschrei
Copy link
Member Author

urschrei commented Apr 3, 2025

Presumably these will start passing when Bullseye-1.86 is published

@michaelkirk
Copy link
Member

I re-kicked the build and the 1.86 build was successful!

But now this:

error: package proj v0.29.0 (/proj-src/build/proj) cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.75.0

geo CI also has MSRV 1.81. Any reason you care about to build containers older than 1.81, or can we drop them?

@urschrei
Copy link
Member Author

urschrei commented Apr 3, 2025

No we can get rid…

@urschrei urschrei force-pushed the shugel/push-lomsxxpwnqrq branch from 58d572a to d6151c4 Compare April 3, 2025 20:07
@@ -22,7 +22,7 @@ jobs:

strategy:
matrix:
rust_version: ["1.75", "1.81", "1.84", "1.85"]
rust_version: ["1.82", "1.85", "1.86"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be 1.81? That's the MSRV we have in geo and proj.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't see your comments in #41. Yeah, let's stick with 1.81 - 1.86 then. This proj situation is such a slog.

@urschrei urschrei force-pushed the shugel/push-lomsxxpwnqrq branch from d6151c4 to 6d6b20b Compare April 3, 2025 20:58
@urschrei
Copy link
Member Author

urschrei commented Apr 3, 2025

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants