Fix UDF referencing #1004
Closed
Fix UDF referencing #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @americast, thanks for submitting the PR. It will be great if you can add a testcase for this to prevent it happening again. Thanks! Also we need to check if this change will exsiting UDFs. |
|
I was looking at the test file https://github.com/georgia-tech-db/evadb/blob/staging/test/unit_tests/executor/test_create_udf_executor.py. I am not able to find the corresponding UDF (or Function) file. I believe a mock file is being used here, but https://github.com/georgia-tech-db/evadb/blob/staging/test/unit_tests/executor/test_create_udf_executor.py#L54 mentions |
|
I will close this PR. We will redesign the UDF setup in #1017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003. Thanks @xzdandy for helping fix this.