write_arrow() does not automatically recognize geometry fields

[paleolimbot]

Very possible there's a flaw in my example, but:

import pyogrio
import pyarrow as pa

tab = pa.table(
    [[b'\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xf0?']],
    schema = pa.schema([
        pa.field("geometry", pa.binary(), metadata={
            "ARROW:extension:name": "geoarrow.wkb",
            "ARROW:extension:metadata": ""
        })
    ])
)

tab.schema.field("geometry").metadata
#> {b'ARROW:extension:name': b'geoarrow.wkb', b'ARROW:extension:metadata': b''}

pyogrio.write_arrow(tab, "foofy.fgb")
#> DataLayerError: Error while writing batch to OGR layer: Cannot find OGR geometry field for Arrow array geometry

[jorisvandenbossche]

Can you try with adding geometry_type="Unknown" to the write call? When geometry_name is specified, we check that you also have to specify geometry_type, but we don't enforce that when the geometry column is inferred.

So either we should raise an error (about having to specify geometry_type) in this case as well, or we should maybe let it default to "Unknown"?