added MATLAB implementation, updated run.sh #59
Conversation
|
Can you make it run in CI? |
|
It should work, but I'm not sure how it handles the licenses. I'll see what I can do with it. |
|
Octave? |
|
Yes, that will probably be the easiest and safest solution. Code runs with both. |
|
Hmm, m is used by objc. |
|
Wow, I did not expect that to happen. I'm not sure what to do at this point then. Matlab does not work with any other extension, I don't know how it is with objc. |
|
@Imaniac230 @geohot .mm can be used for objc file but technically it ll be objc++. |
|
Tried running objc with *.mm, problem is it currently doesn't compile in CI either way. |
|
@Imaniac230 Maybe rename your file as mergesortMatlab.m and it ll go through CI |
|
@gshanbhag525 the matlab version works fine in CI but the objc one spits out an error. I don't know objc so I couldn't make that one compile. |
|
So since there's no way to have both versions at the same time other than changing one of the files anyway I have renamed mine. Please check the compilation of objc in CI though, it doesn't compile. May open up an issue? |
|
@Imaniac230 If you have a mac, there should not be an issue while compiling. |
|
@gshanbhag525 hmm that might be it. I'm talking about the integrated github CI check. The workflow is set to ubuntu-20.04. Or maybe I am missing something? |
|
@geohot why no merge on this one? |
Not sure if useful but adding a version in the MATLAB language. There might be a cleaner way to display the matlab output in the terminal. Most of the delay is by starting up the matlab environment.