Simple overview container

[bentrm]

This is a rather simple container to add an overview control to an application. I wanted to see if it's worth the effort to add tests and docs?

[marcjansen]

Hey @bentrm, I like it, please go ahead if you want to. May I suggest to add a panel to the example with description and also to embed an overview in a layout managed by Ext?

Maybe something like this?

It looks great already!

[chrismayer]

Thank you @bentrm for providing this. Looks really great so far. To be honest I am sure that there are several project solutions for overview map panels out there but none has found the way to the lib. So double thanks for this!

Some little remark: is there a reason why you destroy and re-create the control when size updates?

[marcjansen]

@bentrm, are you still working on this? Shall we provide more help? Just tell us what you think is missing to get this further.

[bentrm]

@marcjansen: Sorry, I didn't have time at hand. I will try to update on this at the end of this week. It shouldn't take to long anyway.

@chrismayer: There is no viable way of updating the dimension of the overview control that I know of. Updating the size of the encapsulated map won't work so people tend to suggest to re-create the control altogether. If I'm overlooking something obvious I'm happy for some input.

[bentrm]

I made some additions and changes. Please let me know what can be improved.

[marcjansen]

Please change to sth. more specific.

[marcjansen]

Hey @bentrm; we're nearly there... good work so far. Please address my comments and this is good to go. Thanks.

I just see that @chrismayer has also added comments, please have a look at them as well.

[chrismayer]

Maybe we can mark this as a non-private readonly property by adding
@property @readonly

[marcjansen]

Yeah, I'd let @bentrm decide this, we're not to strict with this elsewhere anyway.

[bentrm]

I guess it helps browsing the docs, so I'll do just that.

[marcjansen]

👍

[bentrm]

Thanks for your feedback, I hope I didn't overlook something.
JSDuck doesn't have a @public tag so I had to remove it all together to make compiling the docs possible.

[marcjansen]

Some final remarks:

• I'd prefer using split: true instead of a dedicated resizable option (It also feels better for me that only the left border can be used to change the width):

diff --git a/examples/overview/overview-generic.js b/examples/overview/overview-generic.js
index 1b1794c..c09d0f9 100644
--- a/examples/overview/overview-generic.js
+++ b/examples/overview/overview-generic.js
@@ -43,10 +43,7 @@ Ext.application({
                         align: 'stretch'
                     },
                     width: 300,
-                    resizable: {
-                        widthIncrement: 10,
-                        handlers: 'w'
-                    },
+                    split: true,
                     items: [
                         {
                             title: 'Description',
diff --git a/examples/overview/overview.js b/examples/overview/overview.js
index 4a39b22..ac563f7 100644
--- a/examples/overview/overview.js
+++ b/examples/overview/overview.js
@@ -97,10 +97,7 @@ Ext.application({
                         align: 'stretch'
                     },
                     width: 300,
-                    resizable: {
-                        widthIncrement: 10,
-                        handlers: 'w'
-                    },
+                    split: true,
                     items: [
                         {
                             title: 'Description',

• If possible please merge the single commits now into fewer commits. See http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History for help. If this impossible, I can probably do it for you.

This looks great to me.

[bentrm]

There you go. I'm not sure if Travis catches up after a rebase? Edit: It does. Pretty nice.
Thanks for suggesting the split option, that looks much cleaner.

[marcjansen]

Great, I am going to merge this now. Thanks for your patience and continued work on this. I am sure this will render many project solutions useless 😉

[chrismayer]

Yeah, thanks a lot @bentrm ! This is a nice feature. Great work!