Refactor namespace and version setup #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * The GeoExt root object. | ||
| * | ||
| * @class GeoExt |
There was a problem hiding this comment.
Shouldn' t this be @class GeoExt.version ?
|
Hi @marcjansen, thank you for this nice addition. I think this is very helpful. +1 for merging this. |
|
Hey @chrismayer, cheers for your review. I agree with your comments and refactored the class as suggested. Would you mind having another quick glance at this? |
|
Thanks @marcjansen for taking the comments into consideration although they were minor ones and thanks for the ongoing effort! The PR looks very good! All tests still pass. Please merge! |
marcjansen
added a commit
that referenced
this pull request
Oct 26, 2013
Refactor namespace and version setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
GeoExt.Version.versionwhich contains the GeoExt versionGeoExt.Version.environmentwhich will also print the versions of ExtJS and OpenLayersGeoExt.versionan alias forGeoExt.Version.versionPlease review.