Skip to content

Switch almost all AxisLayouts to SimpleAxisLayouts #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
May 2, 2025
Merged

Switch almost all AxisLayouts to SimpleAxisLayouts #1321

merged 33 commits into from
May 2, 2025

Conversation

Alphalaneous
Copy link
Contributor

  • Switch most AxisLayouts to SimpleAxisLayouts, excluding a few that may need a better alternative
  • Clean up some node positioning and sizing
  • Use only short modtober badge to remedy some scaling issues.

These changes also slightly improve the performance of the UI, as AxisLayouts are expensive when updating.

@Alphalaneous
Change mainTabs
ea96b0c
@Alphalaneous
Change backMenu
f85467e
@Alphalaneous
Change actionsMenu and rightActionsMenu
e34332b
@Alphalaneous
Change listDisplayMenu
8e5b239
@Alphalaneous
Change m_pageMenu
13c5f1b
@Alphalaneous
Change m_updateAllMenu, update m_pageMenu layout
9cf100f
@Alphalaneous
Change errorsMenu
92de2d8
@Alphalaneous
Change searchFiltersMenu
aeaac03
@Alphalaneous
Change pageLeftMenu and pageRightMenu
6c61545
@Alphalaneous
change m_statusContainer
43e6e3e
@Alphalaneous
Change m_list->m_contentLayer
f6e342f
@Alphalaneous
Change m_viewMenu
f686360
@Alphalaneous
Change m_titleContainer
2269a8e
@Alphalaneous
Change m_developers, fix m_titleContainer
1ae8a4f
@Alphalaneous
Slight polishing
03dc2a0
@Alphalaneous
Update ModItem.cpp
4be9229
@Alphalaneous
Update ModItem.cpp
8457ea9
@Alphalaneous
Polish some values
add2fba
@Alphalaneous
Smaller gap here
0851192
@Alphalaneous
Fix some scaling
2cd9cdf
@Alphalaneous
No more longtober
02b5712
@Alphalaneous
Tweak min scale of title
5922eac
@Alphalaneous
Increase title space
e565eaa
@Alphalaneous
Clean up Badges on grid view
38707bf 
Fix positioning, scale, and change layout
@Alphalaneous
ModDeveloperItem SimpleRowLayout
1850ba4
@Alphalaneous
ModProblemList SimpleColumnLayout
1e3790b
@Alphalaneous
ModsLayer m_btnMenu SimpleRowLayout
6ebc924
@dankmeme01 dankmeme01 requested a review from Copilot April 30, 2025 17:37
Copilot

This comment was marked as spam.

Sign in to view

@hiimjasmine00
Copy link
Contributor

This is so Fleeyms

@Fleeym
Copy link
Contributor

Fleeym commented Apr 30, 2025

This PR doesn't build without PCH enabled, you should probably fix that.

@Alphalaneous Alphalaneous marked this pull request as draft April 30, 2025 18:02
@Alphalaneous Alphalaneous marked this pull request as ready for review April 30, 2025 18:43
@Fleeym Fleeym merged commit 979dec7 into geode-sdk:main May 2, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alphalaneous @hiimjasmine00 @Fleeym @dankmeme01