Skip to content

Fix iOS FMOD #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 6, 2025
Merged

Fix iOS FMOD #1282

merged 12 commits into from
Apr 6, 2025

Conversation

hiimjasmine00
Copy link
Contributor

My Lord... Is that... legal?

@FireMario211
Copy link
Member

i request that you add assert test for gd version

@matcool
Copy link
Member

matcool commented Apr 4, 2025

maybe make a macro to avoid all the repetition

@hiimjasmine00
Copy link
Contributor Author

i request that you add assert test for gd version

I did that. I guess you couldn't find that in the sea of hooks.

@FireMario211
Copy link
Member

i request that you add assert test for gd version

I did that. I guess you couldn't find that in the sea of hooks.

I did not see that, never mind!

@dankmeme01
Copy link
Member

$on_mod(Loaded) instead of $execute perhaps? I don't know on what thread it runs on ios, but creating hooks on a thread could be problematic

@matcool matcool merged commit b6d637c into geode-sdk:main Apr 6, 2025
6 checks passed
@hiimjasmine00 hiimjasmine00 deleted the fmod branch April 6, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants