Added IDs to web request to prevent incompatibilities between web mods #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJfod
requested changes
Aug 13, 2024
loader/src/utils/web.cpp
Outdated
| WebRequest::WebRequest() : m_impl(std::make_shared<Impl>()) {} | ||
| size_t WebRequest::m_idCounter = 0; | ||
|
|
||
| WebRequest::WebRequest() : m_impl(std::make_shared<Impl>()), m_id(WebRequest::m_idCounter++) {} |
There was a problem hiding this comment.
This is a race condition, WebRequests aren't necessarily created in the same thread
loader/include/Geode/utils/web.hpp
Outdated
| @@ -112,8 +112,9 @@ namespace geode::utils::web { | |||
| private: | |||
| class Impl; | |||
|
|
|||
| static size_t m_idCounter; | |||
There was a problem hiding this comment.
and also static members should be prefixed with s_ not m_
HJfod
approved these changes
Aug 13, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently web mods need to check for pointers to prevent hook recursion. But to prevent the request from being thrown out you also need to copy it. This makes it so there can never be 2 web mods active at the same time.