Consolidate apache arrow imports #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! Would you be able to fix the lint errors? I figure you can just delete the now-unnecessary |
kylebarron
reviewed
Jan 2, 2025
kylebarron
reviewed
Jan 2, 2025
hanbyul-here
force-pushed
the
hanb/import-from-module-index
branch
from
43938f4 to
888f73c
Compare
danielfdsilva
pushed a commit
to danielfdsilva/geoarrow-js
that referenced
this pull request
Feb 6, 2025
* Import from apache arrow root level * Fix lint * Consolidate imports to use the main one
kylebarron
pushed a commit
that referenced
this pull request
Feb 6, 2025
* Import from apache arrow root level * Fix lint * Consolidate imports to use the main one Co-authored-by: Hanbyul Jo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing apache-arrow from root level outputs a lighter (~100kb) bundle. The assets built with subpaths imports included some of the classes and utilities (
Vector,Data.. - which will lead to a problem withisInstanceof) that are supposed to come from apache-arrow.I still think the problem should not be subpath import itself but might be the circular dependencies the subpath modules have - Rollup is trying to resolve the circular dependency by partially importing the package and then embedding the rest of it to the built asset to get out of circular dependency? - I am honestly not sure what exactly is happening here, but importing from root level seems to solve the issue.