Skip to content

fix: small updates to verbiage #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

fix: small updates to verbiage #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c76d2bd
fix: small updates to verbiage
dereklegenzoff Jun 5, 2025
3dcacf4
fixing test
dereklegenzoff Jun 5, 2025
8a3d787
fixing test fr
dereklegenzoff Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gensx/src/commands/build.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export function BuildWorkflowUI({ file, options }: Props) {
)}

{phase === "bundling" && (
<LoadingSpinner message="Building workflows using Docker..." />
<LoadingSpinner message="Building workflows using docker..." />
)}

{phase === "generatingSchema" && (
Expand Down
4 changes: 2 additions & 2 deletions packages/gensx/src/commands/deploy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export const DeployUI: React.FC<Props> = ({ file, options }) => {
)}

{phase === "building" && (
<LoadingSpinner message="Building workflow using docker..." />
<LoadingSpinner message="Building workflows using docker..." />
)}

{phase === "deploying" && (
Expand All @@ -207,7 +207,7 @@ export const DeployUI: React.FC<Props> = ({ file, options }) => {
<Spinner type="dots" />{" "}
<Text dimColor>
Deploying project <Text color="cyan">{projectName}</Text> to
GenSX Cloud <Text dimColor>(Environment:</Text>{" "}
GenSX Cloud <Text dimColor>(environment:</Text>{" "}
<Text color="cyan" dimColor>
{resolvedEnv}
</Text>
Expand Down
4 changes: 2 additions & 2 deletions packages/gensx/tests/commands/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,12 @@ hasCompletedFirstTimeSetup = false
);

// Wait for the build phase to start
await waitForText(lastFrame, /Building workflow using docker\.\.\./);
await waitForText(lastFrame, /Building workflows using docker\.\.\./);

// Check for spinner indicator
const frame = lastFrame();
expect(frame).toBeTruthy();
expect(frame?.includes("Building workflow using docker...")).toBe(true);
expect(frame?.includes("Building workflows using docker...")).toBe(true);
});

it("should show error when build fails", async () => {
Expand Down
Loading