-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Custom JSX runtime #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
49c4fef
to
1648656
Compare
I imported the package into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions/comments, but things are looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and ship it. We can continue reving on the rest and figure out more about type safety as we experiment with LSP/compiler extension support.
cf604d7
to
de14ac8
Compare
Proposed changes
resolve
, components just return their final value directly, or pass it to their children if specified.Further comments
This is a full rewrite of what we had, and requires that consumers of the lib use our JSX runtime (typescript docs). This should not be too much of a hurdle, and gives us full control of the rendering of the tree, and removes the dependency on React.