Fix dynamic terminfo when an alias is used #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error was checked for nil twice. Only need to do so once
Currently, the dynamic terminfo loader will return an empty struct if it encounters that an alias was used. An alias does not mean the output of `infocmp` was incorrect. Set the name to the primary name from `infocmp` and continue processing as necessary. For users who have a terminal not in the internal terminfo database who also may be using an alias TERM (for whatever reason...), the result is that no error is given to the application, and the terminfo struct returns empty strings at runtime...notably the application can't enter the alternate screen and the app is immediately unusable.
gdamore
reviewed
Dec 3, 2023
gdamore
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the dynamic terminfo loader will return an empty struct if it
encounters that an alias was used. An alias does not mean the output of
infocmpwas incorrect. Set the name to the primary name frominfocmpand continue processing as necessary.
For users who have a terminal not in the internal terminfo database who
also may be using an alias TERM (for whatever reason...), the result is
that no error is given to the application, and the terminfo struct
returns empty strings at runtime...notably the application can't enter
the alternate screen and the app is immediately unusable.