Add PersistToDisk property to ChainService #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for enabling shorter timeouts than we would use in a production environment in testing environments, resulting in shorter test execution times. If a timeout isn't provided, we'll use the default of 5 seconds.
We do this to ensure the address manager contains live addresses. Previously, addresses with which we established connections with would not be marked as connected because it would be done once we disconnect peers. Given that we don't process all of the disconnect logic when we're shutting down, addresses of stable and good peers would never be marked as connected unless the connection was lost during operation.
neutrino: refactor OnVersion to instead add peers within OnVerAck
server: Actively prevent regnet network discovery
Previously PersisToDisk is an option to GetCFilter. The problem is that the option is not working well with the in-memory FilterCache. The biggest problem is that if there are two calls of GetCFilter, the first one without the PersistToDisk option, and the second one with the PersistToDisk option, the second one returns the filter from the cache and doesn't write it persistently to the disk. Consequently, if a filter was already queried, there is no way to write it to disk. So for instance if a neutrino user (mainly lnd) is closed before it is fully synchronized, it need to re-download all the filters when it runs again. When handling the PersistToDisk in the ChainService itself, the caller of NewChainService decides in _one place_ if the filters need to be stored in the disk, and that will not depend on the order of calls to GetCFilter.
buck54321
force-pushed
the
persist-to-disk
branch
from
ebd1c85 to
9268e0b
Compare
|
Sorry for the long delay. We are finally getting this project back up and running and love the changes. That being said they need to be rebased against the latest code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightninglabs/neutrino#194