Skip to content

Finish configuration of text-color-secondary with dark color-secondary #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nichtich opened this issue Mar 30, 2025 · 1 comment
Closed
Milestone

Comments

@nichtich
Copy link
Member

color-text-secondary is used against background color color-secondary. This works well in navbar and selected registry but not in concept details and concept tree:

Image

Problems to solve:

  • Default color color-text is applied deep in the nesting of vue components and DOM elements so just using color-text-secondary on a top element does not work
  • Elements are draggable, when dragged, the color should always be color-text
  • Highlighted elements also include buttons

This issue could be solved better by refactoring the components and their CSS (see "plus" icon in the screenshot above, this should have same color instead of two white and grey).

@nichtich
Copy link
Member Author

nichtich commented Mar 31, 2025

Updated. Missing only:

  • hovered concepts in concept tree/list
  • hovered concepts in favorite concepts (this should better be solved by refactoring the dropdown of favorite concepts into a concept list)
  • dragged concepts should not be white (this is a nightmare as it seems to depend on browser)

@nichtich nichtich modified the milestones: 1.12.1, 1.13.0 Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant