Add bitrate param to camera video recorder system #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
8 tasks
Codecov Report
@@ Coverage Diff @@
## locked_entities_camera_record #864 +/- ##
================================================================
Coverage ? 65.74%
================================================================
Files ? 240
Lines ? 17835
Branches ? 0
================================================================
Hits ? 11726
Misses ? 6109
Partials ? 0 Continue to review full report at Codecov.
|
ahcorde
reviewed
Jun 18, 2021
| @@ -379,7 +386,8 @@ void CameraVideoRecorderPrivate::OnPostRender() | |||
| &CameraVideoRecorderPrivate::OnImage, this); | |||
|
|
|||
| this->videoEncoder.Start(this->recordVideoFormat, | |||
| this->tmpVideoFilename, width, height); | |||
| this->tmpVideoFilename, width, height, 25, | |||
There was a problem hiding this comment.
what do you think about adding fps as a parameter too ?
There was a problem hiding this comment.
I'll merge this PR, and add fps this to the locked_entities_camera_record PR.
ahcorde
approved these changes
Jun 18, 2021
nkoenig
approved these changes
Jun 18, 2021
nkoenig
added a commit
that referenced
this pull request
Sep 23, 2021
…862) * Support locked entities, and headless video recording using sim time Signed-off-by: Nate Koenig <[email protected]> * Spelling Signed-off-by: Nate Koenig <[email protected]> * Add bitrate (#864) Signed-off-by: Ian Chen <[email protected]> * Changing Locked name and adding fps Signed-off-by: Nate Koenig <[email protected]> * Rename to unpin Signed-off-by: Nate Koenig <[email protected]> * Fix codecheck Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🎉 New feature
Summary
By default the video recorder records at a bit rate of 2Mbps. The PR adds a
<bitrate>param so users can specify custom bitrate.Test it
edit
camera_video_record_dbl_pendulum.sdfexample world file, and add<bitrate>8000000</bitrate>to the plugin to record a video at 8Mbps.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge