Visualize inertia #861
Merged
Visualize inertia #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atharva Pusalkar <[email protected]>
Signed-off-by: Atharva Pusalkar <[email protected]>
Signed-off-by: Atharva Pusalkar <[email protected]>
Signed-off-by: Atharva Pusalkar <[email protected]>
…into visualize_inertia
Signed-off-by: Atharva Pusalkar <[email protected]>
Signed-off-by: Atharva Pusalkar <[email protected]>
|
Currently |
ahcorde
requested changes
Jun 16, 2021
| { | ||
| ignerr << "Entity with Id: [" << _id << "] already exists in the scene" | ||
| << std::endl; | ||
| return rendering::VisualPtr(); |
There was a problem hiding this comment.
Return the inertia found if exists
There was a problem hiding this comment.
I think it's just returning an empty visual since the entity id is already being used by another visual, similar to the LightVisual
Signed-off-by: Atharva Pusalkar <[email protected]>
…into visualize_inertia
ahcorde
added
the
needs upstream release
…into visualize_inertia
|
@osrf-jenkins retest this please |
|
When this PR is in #888, it should fix the issue with the linter |
…into visualize_inertia
Signed-off-by: Atharva Pusalkar <[email protected]>
ahcorde
approved these changes
Jul 2, 2021
Closed
chapulina
removed
the
needs upstream release
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #111
Summary
Adds the ability to visualize the inertia of models, similar to Gazebo Classic.
Test it
Test it by right-clicking on an entity and selecting
View -> Inertia.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge