-
Notifications
You must be signed in to change notification settings - Fork 302
Added Ellipsoid and Capsule geometries #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: Jenn Nguyen <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
…m/capsule_ellipsoid
Signed-off-by: ahcorde <[email protected]>
…gnitionrobotics/ign-gazebo into ahcorde/geom/capsule_ellipsoid
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde , I pushed commit ac55ced directly to this branch to add an ellipsoid and a capsule to the markers example. It works for me with gazebosim/gz-rendering#276: |
Signed-off-by: Louise Poubel <[email protected]>
The capsule is currently rotated 90 degrees, this fixes it: gazebosim/gz-common#186 |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into it again now, I see that the current implementation doesn't prevent physics engines that don't support capsules and ellipsoids from being loaded. So I think this is good for now. We can always come back and move these shapes into a separate feature if we see the need. Just pending the |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 65.36% 65.34% -0.03%
==========================================
Files 240 240
Lines 17514 17601 +87
==========================================
+ Hits 11448 11501 +53
- Misses 6066 6100 +34
Continue to review full report at Codecov.
|
There are no related failures on CI, merging! |
This PR allows to visualize in Gazebo capsules and ellipsoides.
As you can see in the images I still have some issues with the collisions:
Related with
Signed-off-by: ahcorde [email protected]