Skip to content

Tutorial on migrating SDF files from Gazebo classic #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2021

Conversation

chapulina
Copy link
Contributor

This is just an initial tutorial. Over time, I think we should increment it as we identify other specific pain points.

This is in draft mode until #281 gets in, CC @mjcarroll .

@chapulina chapulina added the documentation Improvements or additions to documentation label Oct 9, 2020
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 9, 2020
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina marked this pull request as ready for review January 14, 2021 21:39
@chapulina chapulina requested a review from maryaB-osr as a code owner January 14, 2021 21:39
@chapulina chapulina requested a review from mjcarroll January 14, 2021 21:54
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #400 (21c2547) into ign-gazebo3 (01fc2ff) will increase coverage by 12.00%.
The diff coverage is 86.66%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #400       +/-   ##
================================================
+ Coverage        65.71%   77.71%   +12.00%     
================================================
  Files              127      208       +81     
  Lines             6238    11595     +5357     
================================================
+ Hits              4099     9011     +4912     
- Misses            2139     2584      +445     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/System.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Component.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
include/ignition/gazebo/gui/GuiRunner.hh 100.00% <ø> (+100.00%) ⬆️
... and 195 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd09d4...21c2547. Read the comment docs.

@chapulina chapulina requested a review from mjcarroll January 27, 2021 06:18
@chapulina chapulina merged commit 39e98e1 into ign-gazebo3 Jan 29, 2021
@chapulina chapulina deleted the chapulina/3/sdf_migration branch January 29, 2021 17:49
@chapulina chapulina added the migration Helps with migration from Gazebo classic to Ignition label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation migration Helps with migration from Gazebo classic to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants