Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom render engines #373

Merged
merged 15 commits into from
Oct 27, 2020
Merged

Add support for custom render engines #373

merged 15 commits into from
Oct 27, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Sep 24, 2020

See gazebosim/gz-rendering#142 for the PR adding this functionality.

Signed-off-by: John Shepherd [email protected]

Update the cmd out
ef96ac4 
Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from chapulina as a code owner September 24, 2020 19:59
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Sep 24, 2020
@JShep1 JShep1 mentioned this pull request Sep 24, 2020
Merged
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Sep 24, 2020
@JShep1 JShep1 requested a review from iche033 as a code owner October 1, 2020 21:43
@JShep1 JShep1 changed the title Update the cmd out for custom render engines Add support for custom render engines Oct 1, 2020
@JShep1 JShep1 mentioned this pull request Oct 2, 2020
Merged
@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #373 into ign-gazebo3 will increase coverage by 11.59%.
The diff coverage is 80.21%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #373       +/-   ##
================================================
+ Coverage        65.71%   77.30%   +11.59%     
================================================
  Files              127      205       +78     
  Lines             6238    11018     +4780     
================================================
+ Hits              4099     8518     +4419     
- Misses            2139     2500      +361
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/gui/plugins/entity_tree/EntityTree.cc 9.89% <0.00%> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1680ebb...6d83f48. Read the comment docs.

chapulina
chapulina suggested changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I tested with ign-rendering's hello world example like this:

cd src/ign-rendering/examples/hello_world_plugin/build
IGN_GAZEBO_RENDER_ENGINE_PATH=`pwd` ign gazebo -v 2 sensors_demo.sdf --render-engine HelloWorldPlugin

Mind adding a tutorial similar to https://github.com/ignitionrobotics/ign-gazebo/blob/main/tutorials/physics.md?

I think you can get most of the way there by copying that tutorial and s/physics/rendering

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Oct 14, 2020
@chapulina
Copy link
Contributor

Removed the "needs upstream release" label because ign-rendering 3.2.0 was released.

Mind updating the minimum required version here?

https://github.com/ignitionrobotics/ign-gazebo/blob/0d16dc96ec0544440a082f37d2cfa72a97dcbc9f/CMakeLists.txt#L117

@JShep1
Copy link
Author

JShep1 commented Oct 20, 2020

Mind adding a tutorial similar to https://github.com/ignitionrobotics/ign-gazebo/blob/main/tutorials/physics.md?

Yep! Tutorial is here and an example is here

@JShep1 JShep1 requested a review from chapulina October 20, 2020 17:19
@chapulina chapulina merged commit 4da55f8 into ign-gazebo3 Oct 27, 2020
@chapulina chapulina deleted the jshep1/update_custom_render_engine_info branch October 27, 2020 00:38
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
@chapulina
Add support for custom render engines (gazebosim#373)
06e7c29 
Signed-off-by: John Shepherd <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
@traversaro traversaro mentioned this pull request Oct 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@chapulina chapulina chapulina approved these changes

Assignees

@JShep1 JShep1

Labels
🏰 citadel Ignition Citadel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JShep1 @chapulina @iche033