Fix mesh import filters not displaying correctly on KDE #2731 #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshnewans
force-pushed
the
mesh_filters
branch
from
65a330f to
f4b709c
Compare
Signed-off-by: Josh Newans <[email protected]>
joshnewans
force-pushed
the
mesh_filters
branch
from
f4b709c to
a6be177
Compare
|
Couple of force-pushes there as my signoff email was somehow broken. |
ahcorde
approved these changes
Jan 27, 2025
|
https://github.com/Mergifyio ign-gazebo6 gz-sim8 |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
|
https://github.com/Mergifyio backport ign-gazebo6 gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Josh Newans <[email protected]> (cherry picked from commit 06e16bc)
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Josh Newans <[email protected]> (cherry picked from commit 06e16bc)
8 tasks
ahcorde
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#2735) Signed-off-by: Josh Newans <[email protected]> (cherry picked from commit 06e16bc) Co-authored-by: Josh Newans <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jan 27, 2025
…#2736) Signed-off-by: Josh Newans <[email protected]> (cherry picked from commit 06e16bc) Co-authored-by: Josh Newans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2731
Summary
Adds labels for mesh import type filter to compensate for a bug (related?) in KDE, but is probably good practice anyway.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.