Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix looking up camera sensor in lens flare system #2559

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 30, 2024

🦟 Bug fix

Summary

The camera_lens_flare.sdf world currently floods the console with the following msgs:

(2024-08-30 22:21:38.752) [error] Unable to find sensor: default::wide_angle_camera_lensflare::link::wide_angle_camera
(2024-08-30 22:21:38.752) [error] Unable to find sensor: default::camera_lensflare::link::camera
(2024-08-30 22:21:38.756) [error] Unable to find sensor: default::wide_angle_camera_lensflare::link::wide_angle_camera
(2024-08-30 22:21:38.756) [error] Unable to find sensor: default::camera_lensflare::link::camera
(2024-08-30 22:21:38.761) [error] Unable to find sensor: default::wide_angle_camera_lensflare::link::wide_angle_camera
(2024-08-30 22:21:38.762) [error] Unable to find sensor: default::camera_lensflare::link::camera

This is likely due to the behavior change introduced in #2546. The PR removes the world prefix from the camera name.

The camera and wide angle camera should now correctly generate images with lens flares

lens_flare_system

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde enabled auto-merge (squash) September 2, 2024 07:14
@ahcorde ahcorde merged commit c4906f8 into gz-sim9 Sep 2, 2024
10 checks passed
@ahcorde ahcorde deleted the fix_camera_lens_system branch September 2, 2024 17:40
@iche033
Copy link
Contributor Author

iche033 commented Sep 19, 2024

@Mergifyio backport gz-sim8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants