Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMAKE_INSTALL_PREFIX to noble github workflow #2539

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 23, 2024

🦟 Bug fix

Summary

Update the installation prefix path so that the INTEGRATION_log_system test is able to find the installed files.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 changed the base branch from gz-sim8 to main August 23, 2024 23:32
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 23, 2024
@iche033 iche033 added 🏛️ ionic Gazebo Ionic and removed 🎵 harmonic Gazebo Harmonic labels Aug 23, 2024
@iche033 iche033 mentioned this pull request Aug 23, 2024
@iche033 iche033 marked this pull request as draft August 23, 2024 23:35
@iche033 iche033 force-pushed the ci_install_prefix branch from e26f778 to 7efebe6 Compare August 23, 2024 23:36
@iche033 iche033 changed the base branch from main to merge_20240821 August 23, 2024 23:36
@iche033 iche033 marked this pull request as ready for review August 24, 2024 01:17
@iche033
Copy link
Contributor Author

iche033 commented Aug 24, 2024

CI is green. Merging this into the 8 -> main forward port PR.

@iche033 iche033 merged commit f519875 into merge_20240821 Aug 24, 2024
9 checks passed
@iche033 iche033 deleted the ci_install_prefix branch August 24, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant