Skip to content

Install the Python libs to system site-packages instead of root #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Install the Python libs to system site-packages instead of root #2274

merged 1 commit into from
Jan 2, 2024

Conversation

oysstu
Copy link
Contributor

@oysstu oysstu commented Jan 2, 2024

🦟 Bug fix

Fixes #2206

Summary

Changes are copied from gz-math

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Occurs when using USE_SYSTEM_PATHS_FOR_PYTHON_INSTALLATION flag.

Signed-off-by: Øystein Sture <[email protected]>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f84b05) 65.62% compared to head (71e77b4) 65.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2274      +/-   ##
===========================================
- Coverage    65.62%   65.61%   -0.01%     
===========================================
  Files          324      324              
  Lines        30925    30925              
===========================================
- Hits         20293    20292       -1     
- Misses       10632    10633       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should be able to simplify the whole logic for Ionic since we're using a newer version of CMake.

@azeey azeey merged commit 9f677bf into gazebosim:gz-sim8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Python system path installation wrong directory
2 participants