Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport sensors system deadlock fix #2200

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 10, 2023

🦟 Bug fix

Summary

Backport #2141

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2200 (79217d9) into gz-sim7 (ba40627) will decrease coverage by 0.02%.
Report is 1 commits behind head on gz-sim7.
The diff coverage is 100.00%.

❗ Current head 79217d9 differs from pull request most recent head 664054c. Consider uploading reports for the commit 664054c to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2200      +/-   ##
===========================================
- Coverage    64.76%   64.75%   -0.02%     
===========================================
  Files          357      357              
  Lines        29134    29136       +2     
===========================================
- Hits         18870    18866       -4     
- Misses       10264    10270       +6     
Files Coverage Δ
src/systems/sensors/Sensors.cc 62.88% <100.00%> (+0.20%) ⬆️

... and 1 file with indirect coverage changes

@iche033 iche033 mentioned this pull request Oct 11, 2023
8 tasks
@iche033 iche033 merged commit ab0669c into gz-sim7 Oct 11, 2023
@iche033 iche033 deleted the backport_sensors_deadlock branch October 11, 2023 17:18
iche033 added a commit that referenced this pull request Oct 16, 2023
@iche033 iche033 mentioned this pull request Oct 16, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants