Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logging tutorial #2148

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Update Logging tutorial #2148

merged 1 commit into from
Sep 14, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 14, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#294

Summary

Removed known issue about playing back being done in ogre. Verified that playback can be done in ogre2

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from mabelzhang as a code owner September 14, 2023 21:01
@iche033 iche033 changed the title Update Loggin tutorial Update Logging tutorial Sep 14, 2023
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #2148 (11a650a) into gz-sim8 (2388193) will not change coverage.
The diff coverage is n/a.

❗ Current head 11a650a differs from pull request most recent head c5b4c1b. Consider uploading reports for the commit c5b4c1b to get more accurate results

@@           Coverage Diff            @@
##           gz-sim8    #2148   +/-   ##
========================================
  Coverage    65.45%   65.45%           
========================================
  Files          323      323           
  Lines        30704    30704           
========================================
  Hits         20096    20096           
  Misses       10608    10608           

@iche033 iche033 merged commit 839282a into gz-sim8 Sep 14, 2023
@iche033 iche033 deleted the log_tutorial branch September 14, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants